SPI support for pse84 and psc3 devices #97820

Peterson-Brett · 2025-10-17T16:58:27Z

Adding SPI PDL driver
Adding spi loopback overlays for pse84
Adding spi loopback overlays for psc3

github-actions · 2025-10-17T16:59:13Z

Hello @Peterson-Brett, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

tbursztyka

just tiny comments, all looks good to me otherwise.

tbursztyka · 2025-10-22T19:39:43Z

drivers/spi/Kconfig.ifx_cat1

+
+config IFX_CAT1_SPI_DMA
+	bool "Infineon CAT1 SPI Interrupt Support"
+	default n


no need to, it's by default unset.

removed 'default n'

tbursztyka · 2025-10-22T19:40:23Z

drivers/spi/spi_ifx_cat1_pdl.c

+	cy_cb_scb_spi_handle_events_t spi_handle_events_func;
+
+	uint8_t cs_oversample_cnt;
+	uint8_t cs_oversample[32];


reverse the order, and move it at the end of the structure

The suggested change has been implemented.

tbursztyka · 2025-10-22T19:41:07Z

drivers/spi/spi_ifx_cat1_pdl.c

+	uint32_t tx_buffer_size;
+	bool is_async;
+	ifx_cat1_event_callback_data_t callback_data;
+	cy_stc_syspm_callback_t spi_deep_sleep;


re-order the attributes so the structure is better aligned.

I think I improved the ordering. @tbursztyka, please let me know if you think more should be done here.

sreeramIfx · 2025-10-22T23:28:02Z

boards/infineon/kit_psc3m5_evk/kit_psc3m5_evk_defconfig

 CONFIG_SERIAL=y
+
+# Main Stack Size
+CONFIG_MAIN_STACK_SIZE=2048


This should be done at the application level as required

This has been removed.

sreeramIfx · 2025-10-22T23:31:24Z

drivers/spi/spi_ifx_cat1_pdl.c

+#define LOG_LEVEL CONFIG_SPI_LOG_LEVEL
+#include <zephyr/logging/log.h>
+LOG_MODULE_REGISTER(cat1_spi);


Suggested change

#define LOG_LEVEL CONFIG_SPI_LOG_LEVEL

#include <zephyr/logging/log.h>

LOG_MODULE_REGISTER(cat1_spi);

#include <zephyr/logging/log.h>

LOG_MODULE_REGISTER(cat1_spi, CONFIG_SPI_LOG_LEVEL);

The suggested change has been implemented.

sreeramIfx · 2025-10-22T23:32:08Z

drivers/spi/spi_ifx_cat1_pdl.c

+#include <zephyr/drivers/pinctrl.h>
+#include <zephyr/drivers/spi.h>
+#include <zephyr/drivers/clock_control/clock_control_ifx_cat1.h>
+#include <zephyr/dt-bindings/clock/ifx_clock_source_common.h>
+
+#ifdef CONFIG_IFX_CAT1_SPI_DMA
+#include <zephyr/drivers/dma.h>
+#endif
+
+#include <zephyr/kernel.h>
+#include <cy_scb_spi.h>
+#include <cy_trigmux.h>


Suggested change

#include <zephyr/drivers/pinctrl.h>

#include <zephyr/drivers/spi.h>

#include <zephyr/drivers/clock_control/clock_control_ifx_cat1.h>

#include <zephyr/dt-bindings/clock/ifx_clock_source_common.h>

#ifdef CONFIG_IFX_CAT1_SPI_DMA

#include <zephyr/drivers/dma.h>

#endif

#include <zephyr/kernel.h>

#include <cy_scb_spi.h>

#include <cy_trigmux.h>

#include <zephyr/drivers/pinctrl.h>

#include <zephyr/drivers/spi.h>

#include <zephyr/drivers/clock_control/clock_control_ifx_cat1.h>

#include <zephyr/dt-bindings/clock/ifx_clock_source_common.h>

#include <zephyr/kernel.h>

#ifdef CONFIG_IFX_CAT1_SPI_DMA

#include <zephyr/drivers/dma.h>

#endif

#include <cy_scb_spi.h>

#include <cy_trigmux.h>

The suggested change has been implemented.

sreeramIfx · 2025-10-22T23:35:30Z

drivers/spi/spi_ifx_cat1_pdl.c

+	cy_stc_scb_spi_config_t scb_spi_config;
+
+	cy_cb_scb_spi_handle_events_t spi_handle_events_func;


Suggested change

cy_stc_scb_spi_config_t scb_spi_config;

cy_cb_scb_spi_handle_events_t spi_handle_events_func;

cy_stc_scb_spi_config_t scb_spi_config;

cy_cb_scb_spi_handle_events_t spi_handle_events_func;

The suggested change has been implemented.

sreeramIfx · 2025-10-22T23:45:03Z

drivers/spi/spi_ifx_cat1_pdl.c

+	} else if (channel == data->dma_tx.dma_channel) {
+
+	} else {
+		printk("Unknown\n");


Suggested change

printk("Unknown\n");

LOG_ERR("Unknown\n");

The suggested change has been implemented.

sreeramIfx · 2025-10-22T23:47:28Z

drivers/spi/spi_ifx_cat1_pdl.c

+	return result;
+}
+
+void ifx_cat1_spi_free(const struct device *dev)


Suggested change

void ifx_cat1_spi_free(const struct device *dev)

void spi_free(const struct device *dev)

The suggested change has been implemented.

sreeramIfx · 2025-10-22T23:47:40Z

drivers/spi/spi_ifx_cat1_pdl.c

+	irq_disable(config->irq_num);
+}
+
+static void ifx_cat1_spi_irq_handler(const struct device *dev)


Suggested change

static void ifx_cat1_spi_irq_handler(const struct device *dev)

static void spi_irq_handler(const struct device *dev)

The suggested change has been implemented.

sreeramIfx · 2025-10-22T23:49:05Z

drivers/spi/spi_ifx_cat1_pdl.c

+	return result;
+}
+
+static cy_rslt_t ifx_cat1_spi_init_hw(const struct device *dev, cy_stc_scb_spi_config_t *cfg)


Suggested change

static cy_rslt_t ifx_cat1_spi_init_hw(const struct device *dev, cy_stc_scb_spi_config_t *cfg)

static cy_rslt_t spi_init_hw(const struct device *dev, cy_stc_scb_spi_config_t *cfg)

The suggested change has been implemented.

sreeramIfx · 2025-10-22T23:49:16Z

drivers/spi/spi_ifx_cat1_pdl.c

+	return result;
+}
+
+cy_rslt_t ifx_cat1_spi_set_frequency(const struct device *dev, uint32_t hz)


Suggested change

cy_rslt_t ifx_cat1_spi_set_frequency(const struct device *dev, uint32_t hz)

cy_rslt_t spi_set_frequency(const struct device *dev, uint32_t hz)

The suggested change has been implemented.

- Updating spi_ifx_cat1_pdl driver to support psc3 and pse84 devices Signed-off-by: Brett Peterson <[email protected]>

- Adding kit_psc3m5_evk overlay for the spi_loopback test Signed-off-by: Brett Peterson <[email protected]>

- Adding pse84 overlay files for the spi_loopback test Signed-off-by: Brett Peterson <[email protected]>

sonarqubecloud · 2025-10-24T18:34:38Z

Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
6.6% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2025-10-25T00:18:43Z

Hi @Peterson-Brett!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

zephyrbot added area: Devicetree Bindings platform: Infineon Infineon Technologies AG area: Tests Issues related to a particular existing or missing test area: SPI SPI bus area: Clock Control area: Boards/SoCs labels Oct 17, 2025

zephyrbot requested review from decsny, mcatee-infineon, nashif, nordic-krch, sreeramIfx, talih0, tbursztyka and teburd October 17, 2025 17:00

zephyrbot assigned tbursztyka Oct 17, 2025

Peterson-Brett force-pushed the psc3-spi branch 3 times, most recently from e1bd17c to 8339b0f Compare October 21, 2025 17:55

sreeramIfx added this to the v4.3.0 milestone Oct 21, 2025

parthitce mentioned this pull request Oct 22, 2025

IFX CAT1: SPI linumiz/zephyr#190

Open

4 tasks

Peterson-Brett force-pushed the psc3-spi branch from 8339b0f to b9bf3ab Compare October 22, 2025 15:24

tbursztyka reviewed Oct 22, 2025

View reviewed changes

sreeramIfx requested changes Oct 22, 2025

View reviewed changes

Peterson-Brett force-pushed the psc3-spi branch from b9bf3ab to 68a01e8 Compare October 23, 2025 22:47

Peterson-Brett requested review from sreeramIfx and tbursztyka October 23, 2025 22:52

tbursztyka previously approved these changes Oct 24, 2025

View reviewed changes

sreeramIfx previously approved these changes Oct 24, 2025

View reviewed changes

drivers: spi: add psc3 and pse84 support

d0978a9

- Updating spi_ifx_cat1_pdl driver to support psc3 and pse84 devices Signed-off-by: Brett Peterson <[email protected]>

Peterson-Brett added 2 commits October 24, 2025 11:03

tests: drivers: spi: spi_loopback: kit_psc3m5_evk support

4358077

- Adding kit_psc3m5_evk overlay for the spi_loopback test Signed-off-by: Brett Peterson <[email protected]>

tests: drivers: spi: spi_loopback: pse84 support

875101e

- Adding pse84 overlay files for the spi_loopback test Signed-off-by: Brett Peterson <[email protected]>

Peterson-Brett dismissed stale reviews from sreeramIfx and tbursztyka via 875101e October 24, 2025 18:06

Peterson-Brett force-pushed the psc3-spi branch from 68a01e8 to 875101e Compare October 24, 2025 18:06

Peterson-Brett requested review from sreeramIfx and tbursztyka October 24, 2025 20:13

tbursztyka approved these changes Oct 24, 2025

View reviewed changes

sreeramIfx approved these changes Oct 24, 2025

View reviewed changes

cfriedt merged commit 4301e69 into zephyrproject-rtos:main Oct 25, 2025
28 checks passed

		cy_stc_scb_spi_config_t scb_spi_config;

		cy_cb_scb_spi_handle_events_t spi_handle_events_func;

	void ifx_cat1_spi_free(const struct device *dev)
	void spi_free(const struct device *dev)

	static void ifx_cat1_spi_irq_handler(const struct device *dev)
	static void spi_irq_handler(const struct device *dev)

	static cy_rslt_t ifx_cat1_spi_init_hw(const struct device dev, cy_stc_scb_spi_config_t cfg)
	static cy_rslt_t spi_init_hw(const struct device dev, cy_stc_scb_spi_config_t cfg)

	cy_rslt_t ifx_cat1_spi_set_frequency(const struct device *dev, uint32_t hz)
	cy_rslt_t spi_set_frequency(const struct device *dev, uint32_t hz)

SPI support for pse84 and psc3 devices #97820

SPI support for pse84 and psc3 devices #97820

Conversation

Peterson-Brett commented Oct 17, 2025

Uh oh!

github-actions bot commented Oct 17, 2025

Uh oh!

tbursztyka left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Oct 24, 2025

Quality Gate passed

Uh oh!

Uh oh!

github-actions bot commented Oct 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants